Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add miro infrastructure map to Docs #2995

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Haroon-Khel
Copy link
Contributor

Thought it would be best for these to be in the docs folder, and then a link to them on the main page. What do people think?

@github-actions github-actions bot added the doc label Mar 15, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@Haroon-Khel Haroon-Khel changed the title Docs: Add infrastrcuture map Miro pdf Docs: Add miro infrastructure map to Docs Mar 15, 2023
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you export these at the same resolution in .gif format instead of .pdf? I suspect the total size will be quite a bit smaller for this sort of image (Currently this will add about 1Mb to the repository which only has about 5½Mb in it which isn't a deal-breaker but it would be nice to avoid it)

Also, please try to avoid creating PR branches in the upstream infrastructure repository - use your own fork.

@sxa
Copy link
Member

sxa commented Apr 3, 2023

/thaw

@github-actions github-actions bot dismissed their stale review April 3, 2023 12:27

Pull Request unblocked - code freeze is over.

@karianna karianna requested a review from sxa April 4, 2023 07:23
@sxa
Copy link
Member

sxa commented Apr 4, 2023

@karianna My previous review still stands

@Haroon-Khel
Copy link
Contributor Author

Can you export these at the same resolution in .gif format instead of .pdf? I suspect the total size will be quite a bit smaller for this sort of image (Currently this will add about 1Mb to the repository which only has about 5½Mb in it which isn't a deal-breaker but it would be nice to avoid it)

Miro does not give me the option to export to .gif

@sxa
Copy link
Member

sxa commented May 19, 2023

For comparison (I screenshotted this on a 1080p display so not perfect) - these are about 150Kb in total.
I wonder if it would make more sense to include these on the wiki instead as a reference.

-rw-r--r--. 1 sxa sxa 32979 May 19 09:58 inframap-other.gif
-rw-r--r--. 1 sxa sxa 26283 May 19 09:58 inframap-dockerhost.gif
-rw-r--r--. 1 sxa sxa 65721 May 19 09:59 inframap-test.gif
-rw-r--r--. 1 sxa sxa 46403 May 19 09:59 inframap-build.gif

inframap-build
inframap-test
inframap-dockerhost
inframap-other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants